Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation: translation of marker factory pattern to chinese #2289 #2757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

translation: translation of marker factory pattern to chinese #2289 #2757

wants to merge 1 commit into from

Conversation

buausb
Copy link

@buausb buausb commented Oct 29, 2023

translation: translation of marker factory pattern to chinese #2289 (comment)

This pull request adds the Chinese translation of the README.md for the 'marker' design pattern, which explains the pattern itself.

  • Created a new README.md file in ch with the translation of the English README.md.
  • Checked for grammar and spelling errors in the translation.

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stale Stale
Copy link

stale bot commented Nov 28, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Nov 28, 2023
@stale Stale
Copy link

stale bot commented Jan 12, 2024

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Jan 12, 2024
@iluwatar iluwatar reopened this Feb 10, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Feb 10, 2024
iluwatar
iluwatar requested changes Feb 10, 2024
View reviewed changes
localization/zh/marker/READEME.md

## 鸣谢

* [Effective Java](https://www.amazon.com/gp/product/0134685997/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=0134685997&linkCode=as2&tag=javadesignpat-20&linkId=4e349f4b3ff8c50123f8147c828e53eb)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename should be README.md

localization/zh/marker/etc/MarkerDiagram.ucls
<operations public="true" package="true" protected="true" private="true" static="true"/>
</classifier-display>
<association-display labels="true" multiplicity="true"/>
</class-diagram>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to copy this file, only the image is needed

localization/zh/marker/etc/marker.urm.puml
@@ -0,0 +1,2 @@
@startuml
@enduml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this file

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@stale Stale
Copy link

stale bot commented Apr 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@buausb @iluwatar