Add links to source files inside README.md #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While the implementation looks perfectly good, I'm concerned that the users don't realize what the link does.
|
|
In Java Design Patterns we use this kind of button as the link
|
|
There's also all these nice Github icons we could use
|
iluwatar
requested changes
Aug 29, 2020
There was a problem hiding this comment.
I think it's better now. Just a couple comments
- I think the github logo should be present in the second link, since that points to the repository. The text of the link could be
Repository link. - Something wrong with one of the links, see the attached screenshot.
iluwatar
approved these changes
Aug 30, 2020
|
Resolves #68, thanks to @grzesiekkedzior 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.