Add Unzip snippet #102
Add Unzip snippet #102
Conversation
There was a problem hiding this comment.
Please fix the CI build. Additionally I see the changes to README.md are missing. Please read through the contribution instructions.
|
Is there anything else to do in order to fix CI build? |
|
I'm available for other needed fixes for the PR. |
|
Sorry for the inconvenience! I forgot checkstyle in testing source code |
README.md
Outdated
| throw new IOException("Failed to create directory " + newFile); | ||
| } | ||
| } else { | ||
| // fix for Windows-created archives |
There was a problem hiding this comment.
Can you elaborate, why this "fix" is needed?
There was a problem hiding this comment.
I've used the main structure proposed in the link you shared in #4 (https://www.baeldung.com/java-compress-and-uncompress chapter 5), but I've never reviewed that case.
I've removed that unnecessary code
There was a problem hiding this comment.
I guess the README.md hasn't been updated with the changes
README.md
Outdated
| throw new IOException("Failed to create directory " + newFile); | ||
| } | ||
| } else { | ||
| // fix for Windows-created archives |
There was a problem hiding this comment.
I guess the README.md hasn't been updated with the changes
| * | ||
| * @param fileZip source zip file | ||
| * @param destDir the directory of the destination unzipped files | ||
| * @throws IOException if an I/O error occurs |
There was a problem hiding this comment.
Please document the @return value too
There was a problem hiding this comment.
Made a new commit, sorry for the problems, I've never used Gradle so I forget all dependencies (and I didn't manage to run Gradle for testing on my machine)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Closed due to inactivity. Thank you for your contributions. |
No description provided.