Fix nvfbc patch failing on driver version 555 (closes #24) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jump instruction that the NvFBC patch was looking for changed quite a bit in 555: it moved and is now an entirely different opcode. This patch is able to find it. I also tweaked the patching process a bit to be able to support multiple different versions of the library, since the new patch won't work on older versions. I tested* on 535, 545, 550, and 555, and all seem to work for me with these changes.
If older versions aren't a concern, then a lot of these changes could be removed and the offset / size information can just be updated instead.
[*] The trunk branch doesn't compile for me so I have to also apply some of the other patches in pull request for testing. Please let me know if I messed up in the cherry-pick for this PR. My original branch that fully works is here.