Merge pull request #173 from feluelle/fix/update-missing-commit

Add missing commit to update
igorbenav · Oct 20, 2024 · f3017e9 · f3017e9
2 parents 1070499 + 38a5a76
commit f3017e9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/fastcrud/crud/fast_crud.py b/fastcrud/crud/fast_crud.py
@@ -2222,6 +2222,8 @@ async def update(
         if return_columns:
             stmt = stmt.returning(*[column(name) for name in return_columns])
             db_row = await db.execute(stmt)
+            if commit:
+                await db.commit()
             if allow_multiple:
                 return self._as_multi_response(
                     db_row,

diff --git a/tests/sqlalchemy/crud/test_update.py b/tests/sqlalchemy/crud/test_update.py
@@ -276,3 +276,7 @@ async def test_update_with_returning(
     )
 
     assert updated_record == expected_result
+
+    # Rollback the current transaction to see if the record was actually committed
+    await async_session.rollback()
+    assert await crud.count(async_session, name="Updated Name") == 1