Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0047 Send ‘close’ stream only if it was not closed #556

Open
wants to merge 2 commits into
base: 4.4
Choose a base branch
from

Conversation

cmeng-git
Copy link
Contributor

@cmeng-git cmeng-git commented Feb 26, 2023

No description provided.

Copy link
Member

@Flowdalic Flowdalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related forum post https://discourse.igniterealtime.org/t/smack-4-4-6-xep-0047-sending-of-close-element-implementation/92455

Why can't we re-use the existing InBandBytestreamSession.isClosed for this?

@Flowdalic
Copy link
Member

Flowdalic commented Mar 24, 2023

Please also see my question regarding re-using isClosed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants