OF-2647: Remove deprecated code #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginServlet.java
Dismissed
Show dismissed
Hide dismissed
xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginServlet.java
Dismissed
Show dismissed
Hide dismissed
xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginServlet.java
Dismissed
Show dismissed
Hide dismissed
xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginServlet.java
Dismissed
Show dismissed
Hide dismissed
|
I have dismissed the four CodeQL check failures. They all relate to uncontrolled (depending on user-provided value) data being used. However, a check exists (it was added as part of OF-1886) that should prevent abuse. |
guusdk
force-pushed
the
2647_Remove-4.8-deprecation
branch
2 times, most recently
from
452c5f9
to
53965bc
Compare
This removes all code that was marked as being deprecated, and to be removed in or after release 4.8.0 Most of the removal revolves around making references to files more type-safe, by moving from String to Path.
guusdk
force-pushed
the
2647_Remove-4.8-deprecation
branch
from
e4e76df
to
c9d1b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all code that was marked as being deprecated, and to be removed in or after release 4.8.0
Most of the removal revolves around making references to files more type-safe, by moving from String to Path.