Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

now keeping tile, petal, and loc #1060

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

now keeping tile, petal, and loc #1060

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4c7cde1
now keeping tile, petal, and loc
iprafols Feb 19, 2024
4ec80b5
removed trailing spaces
iprafols Feb 19, 2024
c026368
fixed bug
iprafols Feb 29, 2024
394ca88
changed tile for tileid for consistency
iprafols Mar 5, 2024
3dab9cb
improved error reporting
iprafols Mar 5, 2024
2daa405
fixed tests
iprafols Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions py/picca/delta_extraction/data_catalogues/desi_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,12 @@ def format_data(self,
"z": row['Z'],
}
args["log_lambda"] = np.log10(spec['WAVELENGTH'])
if "TILEID" in row:
args["tile"] = row['TILEID']
if "PETAL_LOC" in row:
args["petal"] = row['PETAL_LOC']
if "NIGHT" in row:
args["night"] = row['NIGHT']

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add e.g. FIBER or EXPID? Are these fields all read earlier from HDU2 (EXP_FIBERMAP) of the coadd-files, or just when reading spectra-files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked and here we'd just copy over info from the catalogue, is all this info in the actual quasar cats? or would we need to assemble the data from the coadd-files?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly, the FIBER would be nice to have. I'm not sure about the EXPID. @julienguy , what do you think?

if self.analysis_type == "BAO 3D":
forest = DesiForest(**args)
Expand Down
Loading