fix: ensure the prefix follows the same convention as the username #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authenticators have a normalization function that should also be used on the prefix otherwise there might be issues when dealing with checks as the get_authenticated_user method returns a normalized user while authenticate returns the "raw" user.
Since version 5, the logic of check_allowed has changed for a more secure version.
This allows to test current and previous versions of JupyterHub.
sgaist
force-pushed
the
prefix_normalization
branch
from
078f193 to
23a82cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Authenticators have a normalization function that should also be used on the prefix otherwise there might be issues when dealing with checks as the get_authenticated_user method returns a normalized user while authenticate returns the "raw" user.
This PR fixes that by ensuring the prefix is passed through the same normalization method.
Issue ticket number and link
Closes #26