Skip to content

Commit

Permalink
fix(workflows/workflow): apply better fix for the release creation
Browse files Browse the repository at this point in the history
Another python dev is suggesting a fixed version of the file that
is cleaner than what has been done.

For reference:

pypa/packaging.python.org#1323
  • Loading branch information
sgaist committed Nov 3, 2023
1 parent f1ca015 commit f6cf1b3
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,10 @@ jobs:
contents: write # IMPORTANT: mandatory for making GitHub Releases
id-token: write # IMPORTANT: mandatory for sigstore

env:
GH_TOKEN: ${{ github.token }}

steps:
- uses: actions/checkout@v4
- name: Download all the dists
uses: actions/download-artifact@v3
with:
Expand All @@ -143,15 +145,12 @@ jobs:
./dist/*.tar.gz
./dist/*.whl
- name: Create GitHub Release
env:
GH_TOKEN: ${{ github.token }}
run: >-
gh release create
'${{ github.ref_name }}'
--repo '${{ github.repository }}'
--notes ""
- name: Upload artifact signatures to GitHub Release
env:
GH_TOKEN: ${{ github.token }}
# Upload to GitHub Release using the `gh` CLI.
# `dist/` contains the built packages, and the
# sigstore-produced signatures and certificates.
Expand Down

0 comments on commit f6cf1b3

Please sign in to comment.