-
Notifications
You must be signed in to change notification settings - Fork 0
Add testing for Jazzy packages #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emdemir
wants to merge
52
commits into
ros2-jazzy
Choose a base branch
from
feature/jazzy-testing
base: ros2-jazzy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these had previously been created by hand; the rest are automatically generated. The packages still need a bunch of fixes to work, and are missing test definitions. Co-Authored-By: Eddy Gharib <[email protected]>
The Jazzy work had started before the tooling was fully mature and thus we had started work on an older version. This commit hand-merges the original versions to the latest ones from the ROS2 repos.
This is required by @ros2_rcl_interfaces//:test_msgs.
Certain distros set the libdir for 64-bit libraries to /usr/lib64. This change leaks to CMake in rules_foreign_cc, so it can't find the library it just built. This makes it so that the same path is always used.
cyclonedds: Set CMAKE_INSTALL_LIBDIR to lib unconditionally
…ds and removed dep on rules_ros2
The manual definitions for language-specific generators are no longer required.
No functional changes.
This is no longer used and isn't included in the workspace.
These two tests are all the tests present in ros2_rcl_interfaces and they pass.
Required by ros2_rcl tests.
Required by ros2_rcl tests.
A lot of tests are missing but this at least verifies that the package works.
These are unconditionally included in the headers so should be included when building too; otherwise we get missing symbol errors when linking tests.
There are still type support tests and such missing, but this at least verifies package functionality.
6f0541c
to
664a8c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on EddyGharib/rules_ros2#7.
With this, it should be possible to test
ros2_rosidl
,ros2_rcl
andros2_rcl_interfaces
. The first two are not fully covered yet but it's a start and verifies that the packages are built correctly at the basic level.To test, do the following: