-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MMS to ver-1dc #233
base: devel
Are you sure you want to change the base?
Add MMS to ver-1dc #233
Conversation
Job Documentation, step Sync to remote on c84efb3 wanted to post the following: View the site here This comment will be updated on new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review of the weak form discussion. Other aspects of this relevant to the paper have been discussed with @simopier on Slack.
well that took me much longer than I expected 😅 MMS is the most unforgiving kind of test because it catches any mistakes, whether in the C++ code or in the python code used to generate the forcing functions. In my case I made about a billion mistakes in the python code. No errors in TMAP8 itself though! 😄 |
5bb27b2
to
ef03b2a
Compare
Lol my moosedocs build fails spectacularly locally and it's because I cloned tmap8 to have the directory name tmap8 instead of TMAP8 which makes all this code not work: if "/TMAP8/doc/" in script_folder: # if in documentation folder
csv_folder = "../../../../test/tests/ver-1dc/gold/ver-1dc_out.csv"
else: # if in test folder
csv_folder = "./gold/ver-1dc_out.csv" |
step 1: Add description of weak form derivation for case ver-1dc: (Close. #232)
Co-authored-by: Casey Icenhour <[email protected]>
f39082d
to
efcaaba
Compare
efcaaba
to
5bddb0f
Compare
Ugh this is becoming a rabbit hole of how many |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one comment for now.
(Close. #232)