Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MMS to ver-1dc #233

Draft
wants to merge 12 commits into
base: devel
Choose a base branch
from
Draft

Add MMS to ver-1dc #233

wants to merge 12 commits into from

Conversation

simopier
Copy link
Collaborator

@simopier simopier commented Jan 22, 2025

  • step 1: Add description of weak form derivation for case ver-1dc
  • step 2: Apply MMS @lindsayad
  • step 3: Results and discussion @lindsayad

(Close. #232)

@simopier simopier self-assigned this Jan 22, 2025
@moosebuild
Copy link

moosebuild commented Jan 22, 2025

Job Documentation, step Sync to remote on c84efb3 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Jan 22, 2025

Job Coverage, step Generate coverage on c84efb3 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@simopier simopier added documentation Improvements or additions to documentation V&V Relevant to V&V labels Jan 22, 2025
Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review of the weak form discussion. Other aspects of this relevant to the paper have been discussed with @simopier on Slack.

doc/content/verification_and_validation/ver-1dc.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/ver-1dc.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/ver-1dc.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/ver-1dc.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/ver-1dc.md Outdated Show resolved Hide resolved
@lindsayad
Copy link
Member

well that took me much longer than I expected 😅 MMS is the most unforgiving kind of test because it catches any mistakes, whether in the C++ code or in the python code used to generate the forcing functions. In my case I made about a billion mistakes in the python code. No errors in TMAP8 itself though! 😄

@lindsayad
Copy link
Member

Lol my moosedocs build fails spectacularly locally and it's because I cloned tmap8 to have the directory name tmap8 instead of TMAP8 which makes all this code not work:

if "/TMAP8/doc/" in script_folder:     # if in documentation folder
    csv_folder = "../../../../test/tests/ver-1dc/gold/ver-1dc_out.csv"
else:                                  # if in test folder
    csv_folder = "./gold/ver-1dc_out.csv"

@lindsayad
Copy link
Member

Ugh this is becoming a rabbit hole of how many .. to do

Copy link
Collaborator Author

@simopier simopier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one comment for now.

test/tests/ver-1dc/spatial_mms.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation V&V Relevant to V&V
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants