Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vs2019 #870

Merged
merged 19 commits into from
Apr 10, 2022
Merged

Vs2019 #870

merged 19 commits into from
Apr 10, 2022

Conversation

GrahamTheCoder
Copy link
Member

@GrahamTheCoder GrahamTheCoder commented Apr 9, 2022

Closes #866

  • Look into VB standalone statement tests
  • Check what's happening in SpecialConversionTests with clashing identifiers
  • Release master (8.5.0) before this is merged (which has a message encouraging upgrading VS)

@christophwille
Copy link
Member

How about a "legacy" gh release linked from README? Easily discoverable and side loading always works with VS.

@GrahamTheCoder
Copy link
Member Author

Yeah, I think let's just do that, and make it as clear as possible on the readme, and extension page where to get an old version so that people don't get confused and/or raise lots of issues about it.

@GrahamTheCoder GrahamTheCoder marked this pull request as ready for review April 10, 2022 16:28
@GrahamTheCoder GrahamTheCoder merged commit bf90c93 into master Apr 10, 2022
@GrahamTheCoder GrahamTheCoder deleted the vs2019 branch April 10, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for VS2017 - enable support for newer language features
3 participants