-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VB -> C#: Improve query syntax support #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I'd like to write a few more tests to get this bit merged before moving on to the other points. I'm slightly worried some cases may be worse on this branch still |
9db166d
to
601e215
Compare
Rather difficult to follow code - really needs a refactor
This was referenced Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29
Problem
Currently don't handle several keywords, or nested statements
Solution
First step was to handle nested statements by chunking sections together.
At least one test covering the code changed
All tests pass
Which part of this PR is most in need of attention/improvement:
QueryConverter
are pretty much write-only code. They just batch up bits of the query for other methods to handle later, but are missing appropriate naming and probably a data structure of their own.Single
in places where there can be multiple elements - I don't have examples of the more advanced cases, so I think this is fine for now, and better than barreling on missing information without informing the user.