2024.10.17 preset extensions #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treece-Burgess
requested changes
Nov 19, 2024
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
4 times, most recently
from
935ea80 to
eaa020e
Compare
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
4 times, most recently
from
b57602c to
6c536d1
Compare
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
2 times, most recently
from
1212e11 to
6406ed1
Compare
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
12 times, most recently
from
34fb833 to
c8727c1
Compare
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
2 times, most recently
from
de36142 to
a4c22a4
Compare
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
from
1c3178f to
2d0d73c
Compare
Contributor
Author
|
Please do not merge yet. |
jagode
requested changes
Apr 24, 2025
Collaborator
jagode
left a comment
jagode
left a comment
There was a problem hiding this comment.
Since we already have PAPI_L3-related presets, I’m not a fan of introducing a second set of L3-related events just because the native events now come from a different component (uncore, in this case). That is an internal technical detail that users shouldn’t have to worry about. It could create confusion if the original L3 presets are not defined while the new, slightly different L3-uncore presets are defined.
@adanalis : What do you think?
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
from
2d0d73c to
ee66986
Compare
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
4 times, most recently
from
511a569 to
0d7f082
Compare
Treece-Burgess
approved these changes
May 5, 2025
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
from
0d7f082 to
049bf95
Compare
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
from
049bf95 to
b6b2203
Compare
jagode
approved these changes
May 7, 2025
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
from
b6b2203 to
82887a3
Compare
Create fields in the vector struct for components to define presets. These changes have been tested on the NVIDIA Hopper architecture.
Add functions to facilitate CUDA presets. These changes have been tested on the NVIDIA Hopper architecture.
Update configure to track both the number of presets per component and the arrays of presets belonging to each component. These changes have been tested on the NVIDIA Hopper architecture.
Updates to framework to facilitate preset events defined by native events of non-perf_event components. These changes have been tested on the NVIDIA Hopper architecture.
This is an aesthetic change to improve the development process. These changes have been tested on the NVIDIA Grace-Hopper architecture.
Replace modifiers with only those that enumerate the CPU preset events. These changes have been tested on the NVIDIA Grace-Hopper architecture.
Enumerate presets for components as well as the CPU. These changes have been tested on the NVIDIA Grace-Hopper architecture.
dbarry9
force-pushed
the
2024.10.17_preset-extensions
branch
from
82887a3 to
c214d8c
Compare
This was referenced May 13, 2025
3 tasks
dbarry9
added a commit
that referenced
this pull request
Jun 12, 2025
PR #284 introduced code that always forced the initialization of all components. However, this defeats the purpose of having PAPI_EDELAY_INIT. The changes in this pull request only force initialization of components when necessary. These changes have been tested on systems containing: - NVIDIA Hopper architecture - AMD Zen3 CPU and AMD MI250X GPU architectures (Frontier).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds support for presets defined using native events from non-CPU components. The only component that has been modified in this PR is the 'cuda' component, which is limited to loading the preset table for 'cuda' presets.
These changes have been tested on the NVIDIA Grace-Hopper architecture.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests