-
Notifications
You must be signed in to change notification settings - Fork 111
Updating earthaccess and fixing a few minor bugs. #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #715 +/- ##
===============================================
+ Coverage 65.65% 65.66% +0.01%
===============================================
Files 37 37
Lines 3051 3052 +1
Branches 396 396
===============================================
+ Hits 2003 2004 +1
Misses 971 971
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea what precommit is changing here (and why it wasn't done in the PR that updated these figures, #716?)
|
|
||
| import re | ||
|
|
||
| track_str = "Unknown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this addressing a particular issue, or just a good practice so we have something to return (in which case, should we also add similar lines for spot_dim_name and spot_var_name?
| name = "icepyx" | ||
| description = "Python tools for obtaining and working with ICESat-2 data" | ||
| license = {file = "LICENSE"} | ||
| license = { file = "LICENSE" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea what's causing the reformatting? I don't know enough about how local settings can cause changes (vs what's in the icepyx precommit config file) to figure out if somehow this file hasn't been linted before or if it was linted on your fork with different settings.
No description provided.