Skip to content

Conversation

@betolink
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Binder 👈 Launch a binder notebook on this branch for commit 9090abc

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 5016a38

Binder 👈 Launch a binder notebook on this branch for commit c8451c8

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.66%. Comparing base (655d67b) to head (c8451c8).

Files with missing lines Patch % Lines
icepyx/core/orders.py 0.00% 1 Missing ⚠️
icepyx/core/read.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #715      +/-   ##
===============================================
+ Coverage        65.65%   65.66%   +0.01%     
===============================================
  Files               37       37              
  Lines             3051     3052       +1     
  Branches           396      396              
===============================================
+ Hits              2003     2004       +1     
  Misses             971      971              
  Partials            77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@betolink betolink marked this pull request as ready for review October 21, 2025 03:00
@betolink betolink changed the title [DNM] Updating earthaccess and fixing a few minor bugs. Updating earthaccess and fixing a few minor bugs. Oct 21, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what precommit is changing here (and why it wasn't done in the PR that updated these figures, #716?)


import re

track_str = "Unknown"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this addressing a particular issue, or just a good practice so we have something to return (in which case, should we also add similar lines for spot_dim_name and spot_var_name?

name = "icepyx"
description = "Python tools for obtaining and working with ICESat-2 data"
license = {file = "LICENSE"}
license = { file = "LICENSE" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea what's causing the reformatting? I don't know enough about how local settings can cause changes (vs what's in the icepyx precommit config file) to figure out if somehow this file hasn't been linted before or if it was linted on your fork with different settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants