Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.9 and 3.10 #655

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from
Draft

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Feb 12, 2025

Set minimum required Python version to 3.11+, following SPEC 0. Dropping support prior to icepyx v2.x release.

Merge this after #622.

Supersedes #608, addresses #569

@weiji14 weiji14 self-assigned this Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

Binder 👈 Launch a binder notebook on this branch for commit e02be9b

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 52ebecf

Binder 👈 Launch a binder notebook on this branch for commit 0fcfb89

Binder 👈 Launch a binder notebook on this branch for commit 3ec0207

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.80%. Comparing base (c66fd72) to head (3ec0207).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #655      +/-   ##
===============================================
- Coverage        66.90%   66.80%   -0.10%     
===============================================
  Files               35       35              
  Lines             3058     3058              
  Branches           422      422              
===============================================
- Hits              2046     2043       -3     
- Misses             925      928       +3     
  Partials            87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@betolink
Copy link
Contributor

@weiji14 when do you think we can merge this? not a blocker just wanted to merge your branch into the PR I'm working on but my PR goes to a branch so no worries.

@weiji14
Copy link
Member Author

weiji14 commented Feb 19, 2025

I was gonna wait for @JessicaS11 to merge #622, and then we can merge this to have 3 Python versions supported at least (3.11, 3.12, 3.13).

@JessicaS11
Copy link
Member

#622 is merged; this looks good to me. r.e. #569, should we add a note to the docs around SPEC0 to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants