Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
cosmic-text
to0.11
andresvg
to0.41
.It seems there may be a bit of a performance regression with this update—I am noticing a ~5% increase in render time in most of the examples.
I created a new "layered text" benchmark and it caught a 2% regression:
The benchmark tests static text, so I suspect the regression caught here may be caused by the hashing of
CacheKey
—which now includes an additionalCacheKeyFlags
field.I suspect regressions here are normal since these libraries are still evolving, getting more complex, and satisfying more use cases. In any case, I figured I'd share my results just in case someone may feel like investigating further.
Also important to mention that I originally updated my
glyphon
fork to catch up to themain
branch upstream, but apparently that introduces yet another regression—a bigger one!I suspect the main culprit here is the additional bind group changes introduced by grovesNL/glyphon#88, specially when using multiple
TextRenderer
instances (precisely the scenario of the benchmark!).