-
Notifications
You must be signed in to change notification settings - Fork 2
circles example #2
base: main
Are you sure you want to change the base?
Conversation
@13r0ck I saw, that here the author included the Cargo.lock file and a gitignore file. How do you want to proceed here? Include both files or leave them out? I didn't include one in #1 and prefer leaving them out since
|
@TheRittler yep, I agree. I still like the idea of having a .gitignore just to help prevent people from accidentally committing their /target, what do you think about having one gitignore at the root for the repo? |
I'd like that! |
The reason I included |
@DavidBJaffe That is a good point. I do lean towards removing |
Ah interesting, I hadn't thought of that! So are we in agreement to kill |
Yep. I have a few small changes to request in your two PRs that I will get to late this afternoon/tomorrow morning. Then we can get your PRs merged! |
Add example illustrating: