remove nans in llh map only when calculating contours. Otherwise, nan…

…s are kept
icecube · Dec 10, 2024 · a482ffd · a482ffd
1 parent c17903b
commit a482ffd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/skyreader/plot/plot.py b/skyreader/plot/plot.py
@@ -449,16 +449,12 @@ def bounding_box(ra, dec, theta, phi):
 
         if not circular:
             if llh_map:
-                # get rid of nan values only for the contours and
-                # avoiding crashes during plotting
-                max_map = np.nanmax(equatorial_map)
+                # get rid of nan values only for the contours
+                # this avoids crashes during plotting
                 grid_values_for_contours = copy.copy(grid_value)
                 grid_values_for_contours[
                     np.isnan(grid_values_for_contours)
-                ] = max_map
-                #grid_values_for_contours = grid_values_for_contours.clip(
-                #    None, max_map
-                #)
+                ] = np.nanmax(equatorial_map)
                 contour_levels_for_contours = contour_levels
             else:
                 grid_values_for_contours = np.log(grid_value)

diff --git a/skyreader/utils/handle_map_data.py b/skyreader/utils/handle_map_data.py
@@ -111,11 +111,6 @@ def extract_map(
         # show 2 * delta_LLH
         grid_value = grid_value * 2.
         equatorial_map *= 2.
-
-        #max_map = np.nanmax(equatorial_map)
-        #equatorial_map[np.isnan(equatorial_map)] = max_map
-        #grid_value[np.isnan(grid_value)] = max_map
-        #grid_value = grid_value.clip(None, max_map)
     else:
         # Convert to probability
         equatorial_map = np.exp(-1. * equatorial_map)