fix: asof_join for columns with different names#11781
Open
mesejo wants to merge 2 commits intoibis-project:mainfrom
Open
fix: asof_join for columns with different names#11781mesejo wants to merge 2 commits intoibis-project:mainfrom
mesejo wants to merge 2 commits intoibis-project:mainfrom
Conversation
mesejo
force-pushed
the
fix/asof_join_diff_col_names
branch
from
d78f060 to
0c31479
Compare
NickCrews
force-pushed
the
fix/asof_join_diff_col_names
branch
from
7062692 to
55b878b
Compare
Contributor
|
@mesejo I added a followup commit adding some more tests for the string join case, since there is some if/else going on in this branch that I wanted to test. If that passes, then LGTM! |
Contributor
Author
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
These changes solve the issue referenced by binding the column of the original left table onto the filtered table (the one resulting from applying the tolerance after the
asof_join)One of the tests of asof_join was expanded to account for any regression.
Issues closed
Notes
The bug probably comes from the fact that the pandas API only accepts column names (
label) as input for theonargument.