Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for CURLOPT_SSL_VERIFYPEER #32

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Temporary fix for CURLOPT_SSL_VERIFYPEER #32

wants to merge 9 commits into from

Conversation

Niellles
Copy link
Contributor

@Niellles Niellles commented Jul 2, 2018

CURLOPT_SSL_VERIFYPEER shouldn't be set to false as this possibly weakens security.1 2

These fixes attempt to do the request with certificate verification and disable it if the request fails. Followed by a new curl attempt.

  1. Issue: Enable CURLOPT_SSL_VERIFYPEER option #18
  2. https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html

@Niellles Niellles changed the title CURLOPT_SSL_VERIFYPEER on StravaApi.php:129 is now set to (bool)true. Temporary fix for CURLOPT_SSL_VERIFYPEER Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant