Save notes when dialog closes (screen rotation, screen turned off, user accidentally clicked outside the dialog) #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er accidentally clicked outside the dialog)
| @@ -77,4 +79,17 @@ class CheckmarkDialog : AppCompatDialogFragment() { | |||
|
|
|||
| return dialog | |||
| } | |||
|
|
|||
| override fun onDestroyView() { | |||
| if (!wasSaved) { | |||
There was a problem hiding this comment.
Don't save if user clicked one of values [✓, X, ? , -] to save the event.
|
|
||
| override fun onDestroyView() { | ||
| if (!wasSaved) { | ||
| save(requireArguments().getInt("value")) |
There was a problem hiding this comment.
If Dialog is closed by dismissCurrentDialog(), save note with previous value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extensively add notes to my tracked habits, and it's frustrating when my whole note disappears when I accidentally rotate the screen or my screen turns off.
I noticed that Dialogs are closed on purpose (
dismissCurrentDialoginonPause()), because callbacks are cleared after rotation. Fixing it would involve architecture changes, so I added a quick fix instead to autosave notes when the dialog closes.