Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt .multiSelectionResponsive to recent changes in iSEE #2

Open
wants to merge 3 commits into
base: kra-1
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ jobs:
fail-fast: false
matrix:
config:
- { os: ubuntu-latest, r: 'devel', bioc: '3.20', cont: "bioconductor/bioconductor_docker:devel", rspm: "https://packagemanager.rstudio.com/cran/__linux__/jammy/latest" }
- { os: macOS-latest, r: 'devel', bioc: '3.20'}
- { os: windows-latest, r: 'devel', bioc: '3.20'}
- { os: ubuntu-latest, r: 'devel', bioc: '3.21', cont: "bioconductor/bioconductor_docker:devel", rspm: "https://packagemanager.rstudio.com/cran/__linux__/jammy/latest" }
- { os: macOS-latest, r: 'devel', bioc: '3.21'}
- { os: windows-latest, r: 'devel', bioc: '3.21'}
## Check https://github.com/r-lib/actions/tree/master/examples
## for examples using the http-user-agent
env:
Expand Down Expand Up @@ -191,7 +191,7 @@ jobs:
gha_repos <- if(
.Platform$OS.type == "unix" && Sys.info()["sysname"] != "Darwin"
) c(
"AnVIL" = "https://bioconductordocker.blob.core.windows.net/packages/3.20/bioc",
"AnVIL" = "https://bioconductordocker.blob.core.windows.net/packages/3.21/bioc",
BiocManager::repositories()
) else BiocManager::repositories()

Expand Down
5 changes: 5 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
export(SampleIdentificationCenter)
exportClasses(SampleIdentificationCenter)
exportMethods(.createObservers)
exportMethods(.defineDataInterface)
exportMethods(.defineOutput)
exportMethods(.definePanelTour)
exportMethods(.fullName)
exportMethods(.generateOutput)
exportMethods(.multiSelectionResponsive)
exportMethods(.panelColor)
exportMethods(.renderOutput)
exportMethods(initialize)
Expand All @@ -19,10 +21,13 @@ importClassesFrom(iSEE,Panel)
importFrom(iSEE,.emptyDefault)
importFrom(methods,callNextMethod)
importFrom(methods,new)
importFrom(shiny,HTML)
importFrom(shiny,nearPoints)
importFrom(shiny,renderPlot)
importFrom(shiny,renderUI)
importFrom(shiny,span)
importFrom(shiny,tagList)
importFrom(shiny,textInput)
importFrom(shiny,uiOutput)
importFrom(shiny,wellPanel)
importFrom(shinyAce,aceEditor)
Expand Down
9 changes: 3 additions & 6 deletions R/panel_SampleIdentificationCenter.R
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ setMethod("initialize", "SampleIdentificationCenter", function(.Object, ...) {
# TODO - placeholder

#' @export
#' @importFrom shiny tagList
#' @importFrom shiny tagList textInput span HTML
setMethod(".defineDataInterface", "SampleIdentificationCenter", function(x) {
panel_name <- .getEncodedName(x)

Expand Down Expand Up @@ -246,11 +246,8 @@ setMethod(".renderOutput", "SampleIdentificationCenter", function(x, se, output,
# Transmission -----------------------------------------------------------------

#' @export
setMethods(".multiSelectionResponsive", "SampleIdentificationCenter", function(x, dims = character(0)){
if ("column" %in% dims) {
return(TRUE)
}
return(FALSE)
setMethod(".multiSelectionResponsive", "SampleIdentificationCenter", function(x, dim = character(0)) {
dim == "column"
})

# Tour definition --------------------------------------------------------------
Expand Down
6 changes: 3 additions & 3 deletions man/SampleIdentificationCenter-class.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading