Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update machine references to node #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

l00ps
Copy link

@l00ps l00ps commented Dec 17, 2023

This PR fixes #128

@davidfreina
Copy link

I think you missed one replacement of 'machine'.
In the renderer.py on line 352 the machine page fail to load with a 502 if it enters this if-clause because the app.logger.debug statement still contains a reference to routes['machine'] which should be replaced with routes['node'].
I have opened a PR to your branch to fix this last reference (l00ps#2).

@ClashTheBunny
Copy link

Would a more robust way of doing this support both the old version and the new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API calls to /machine are deprecated; use /node
4 participants