Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string: respect removeEmpty when VarList input is empty #7

Merged
merged 1 commit into from
Jul 4, 2024
Merged

string: respect removeEmpty when VarList input is empty #7

merged 1 commit into from
Jul 4, 2024

Conversation

PaideiaDilemma
Copy link
Contributor

@PaideiaDilemma PaideiaDilemma commented Jul 4, 2024 •
edited
Loading

Makes VarList respect removeEmpty when in is empty.

I think it does not cause any negative side effects, because operator[] will return an empty string, when idx >= m_vArgs.size() anyways.

Or is it intended behaviour that CVarList always contains at least one arguement?

Motivated by hyprwm/hyprlock#396

@PaideiaDilemma PaideiaDilemma mentioned this pull request Jul 4, 2024
Merged
vaxerski
vaxerski approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit 259ecfa into hyprwm:main Jul 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaideiaDilemma @vaxerski