Skip to content

Conversation

@mwahstache
Copy link
Contributor

Sorry if this is not formatted correctly, I've never made a PR before.

The old logic for colresize -conf was not correct, since if m_config.configuredWidths did not contain any elements smaller than the currently focused window, then this check:

if (m_config.configuredWidths[i] > WDATA->column->columnWidth)
    continue;

would pass even when i=0, causing an underflow for i, and (at least when was running it) crashing hyprland immediately afterwards because it was indexing way out of bounds (I haven't been able to get the nested session to work properly on my system so I couldn't tell you what exactly was crashing it, but I assume it was just a segfault).

I fixed this and simplified the logic a bit, and I also changed the logic for colresize +conf to match my changes for -conf.

@mwahstache mwahstache closed this Nov 19, 2025
@mwahstache mwahstache reopened this Nov 19, 2025
@mwahstache mwahstache force-pushed the main branch 2 times, most recently from 2381d0e to 6cd2bf6 Compare November 19, 2025 11:38
@vaxerski
Copy link
Member

build fails

@mwahstache
Copy link
Contributor Author

Isn't that because the build for hyprbars is failing currently? At least, that's what I gathered from the logs.

@vaxerski
Copy link
Member

yeah needed a rebase I think

@vaxerski vaxerski merged commit a707757 into hyprwm:main Nov 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants