[hyprscrolling] fixed logic for colresize when called with -conf #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry if this is not formatted correctly, I've never made a PR before.
The old logic for
colresize -confwas not correct, since ifm_config.configuredWidthsdid not contain any elements smaller than the currently focused window, then this check:would pass even when
i=0, causing an underflow fori, and (at least when was running it) crashing hyprland immediately afterwards because it was indexing way out of bounds (I haven't been able to get the nested session to work properly on my system so I couldn't tell you what exactly was crashing it, but I assume it was just a segfault).I fixed this and simplified the logic a bit, and I also changed the logic for
colresize +confto match my changes for-conf.