feature: add simple labels for named workspaces #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the option to show workspace name labels (works with named workspaces). kept it as simple and unopinionated as possible
fixed the labelanchor access error leftover from the previous refractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to show workspace name labels (works with named workspaces).
show_labels : boolean | whether to show workspace name labels
label_fontsize: number | font size for workspace labels (minimum 8)
label_anchor: label position:
tl,tr,bl,br,tc,bc,cl,cr,cc(top-left, top-right, bottom-left, bottom-right, top-center, bottom-center, center-left, center-right, center)I saw there was a similar option in a pending big PR but it seemed somewhat overkill and didn't take into account named workspace and only numeric ones centered in the middle of the previews.
Maybe the following would be a good compromise for both parts?