-
-
Notifications
You must be signed in to change notification settings - Fork 143
[hyprexpo] enhancement: outer gaps, workspace selection, workspace enumeration, tile rounding, multi-monitor #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dskvr
wants to merge
25
commits into
hyprwm:main
Choose a base branch
from
sandwichfarm:feature/better-hyprexpo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
this MR will have to wait a moment for #496 to be merged first as it changes the structure a bit |
Author
|
I found an issue related to multi-monitor support anyways, need to refactor some things. |
* Hyprscrolling: (feat) Add `togglefit` command * fix multi-workspaces bugs and focus change bug. * fix center to fitcol bug * remove "fullyvisible" logic to simplify the logic
… backwards compatibility
…errides plugin config (if present)
7d55cba to
ea8966a
Compare
Author
|
minor refactor to support future upstream and rebased Notes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #123
Summary
This PR adds comprehensive keyboard-driven workspace selection to Hyprexpo, mouse hover feedback, per-monitor workspace configuration, numbered labels with rich styling, configurable inner/outer gaps, native Hyprland-style gradient borders with auto-detection, and rounded tiles with per-state overrides.
Highlights
hyprexpo_workspace_methodkeywordgaps_inandgaps_outfor clean spacingborder_color_*config supports both solid colors (rgb(66ccff)) and gradients (rgba(33ccffee) rgba(00ff99ee) 45deg)Why
Key Features
Keyboard Navigation
hyprexpo:kb_focus <left|right|up|down>: Move keyboard focushyprexpo:kb_confirm: Select focused tilehyprexpo:kb_selecti <index>: Select by 1-based visual index (recommended; enables 1-key selection)hyprexpo:kb_selectn <id>: Select by workspace ID (legacy; 0→10)hyprexpo:kb_select <token>: Single-character token (1-9, 0, a-z)hyprexpowhile overview is open (configurable viakeynav_enable)keynav_wrap_h,keynav_wrap_v)Mouse Hover
border_color_hover)tile_rounding_hover)Multi-Monitor Support
workspace_methodfor per-monitor configurationworkspace_method = MONITOR_NAME <center|first> <workspace>plugin:hyprexpo:workspace_methodfor monitors without specific configLabels (Numbers)
token(default) |index|idlabel_token_mapup to 50 comma-separated tokens (empty entries skip labels)Borders (Auto-Detecting)
border_color_*auto-detects format:rgb(66ccff)or0xFF66CCFFrgba(33ccffee) rgba(00ff99ee) 45degCGradientValueData+renderBorderwith proper rounded corner supportGaps
gaps_in: Inner spacing between tilesgaps_out: Outer margin around the grid (animated during open/close)Config Changes (Breaking / Migration)
Removed/Deprecated
→gap_sizegaps_inBorder Format
Supports solid and hyprland-style gradient borders (via native api)
Minimal Migration Example
plugin { hyprexpo { # Spacing gaps_in = 5 gaps_out = 0 # Borders (auto-detecting format) border_width = 2 border_color_current = rgba(33ccffee) rgba(00ff99ee) 45deg # Gradient border_color_focus = rgb(ffcc66) # Solid border_color_hover = rgb(aabbcc) # Solid # Tiles (rounded corners with per-state overrides) tile_rounding = 12 tile_rounding_power = 2.0 tile_rounding_focus = -1 # -1 = inherit from tile_rounding tile_rounding_current = -1 tile_rounding_hover = -1 # Keyboard navigation keynav_enable = 1 keynav_wrap_h = 1 keynav_wrap_v = 1 # Labels (defaults to centered with background bubble) label_enable = 1 label_text_mode = token # token | index | id label_bg_enable = 1 label_bg_shape = circle label_padding = 8 label_pixel_snap = 1 } } # Per-monitor workspace methods (optional, at top level) workspace_method = DP-1 first 1 workspace_method = HDMI-A-1 center currentNew Options (Grouped)
Keyboard Navigation
plugin:hyprexpo:keynav_enable(int/bool): default1plugin:hyprexpo:keynav_wrap_h,plugin:hyprexpo:keynav_wrap_v: default1plugin:hyprexpo:keynav_reading_order: default0(spatial)Borders (Auto-Detecting)
plugin:hyprexpo:border_width(int): default2plugin:hyprexpo:border_color(string): default border for unused tilesplugin:hyprexpo:border_color_current(string): defaultrgb(66ccff)plugin:hyprexpo:border_color_focus(string): defaultrgb(ffcc66)plugin:hyprexpo:border_color_hover(string): defaultrgb(aabbcc)Tile Rounding
plugin:hyprexpo:tile_rounding(int): default0plugin:hyprexpo:tile_rounding_power(float): default2.0plugin:hyprexpo:tile_rounding_focus(int): default-1(inherit)plugin:hyprexpo:tile_rounding_current(int): default-1(inherit)plugin:hyprexpo:tile_rounding_hover(int): default-1(inherit)Gaps
plugin:hyprexpo:gaps_in(int): default5plugin:hyprexpo:gaps_out(int): default0Labels: Placement and Visibility
plugin:hyprexpo:label_enable(int/bool): default1plugin:hyprexpo:label_position:top-left|top-right|bottom-left|bottom-right|centerplugin:hyprexpo:label_offset_x,label_offset_y(int): default0plugin:hyprexpo:label_show:always|hover|focus|hover+focus|current+focus|neverLabels: Per-State and Font
plugin:hyprexpo:label_color_default|hover|focus|current(int colors)plugin:hyprexpo:label_scale_hover,label_scale_focus(float): default1.0plugin:hyprexpo:label_font_family(string): defaultSansplugin:hyprexpo:label_font_size(int): default16plugin:hyprexpo:label_font_bold,label_font_italic(int): default0plugin:hyprexpo:label_text_underline,label_text_strikethrough(int): default0Labels: Container and Precision
plugin:hyprexpo:label_bg_enable(int/bool): default1plugin:hyprexpo:label_bg_shape:circle|square|roundedplugin:hyprexpo:label_bg_color(int): default0x88000000plugin:hyprexpo:label_bg_rounding(int): default8plugin:hyprexpo:label_padding(int): default8plugin:hyprexpo:label_pixel_snap(int): default1plugin:hyprexpo:label_center_adjust_x,label_center_adjust_y(int): optical nudgeplugin:hyprexpo:label_text_mode:token|index|idplugin:hyprexpo:label_token_map(string): up to 50 comma-separated tokensUsage (Bindings)
Recommended submap (auto-entered if
keynav_enable = 1):Testing
Implementation Notes
COverviewand integrates with render pass to highlight focus/current/hoverg_monitorWorkspaceMethodswith monitor name keys, falls back to plugin configisGradientBorderSpec()checks for dualrgba()pattern; parsesrgb()or hex for solid colorsCGradientValueData+CHyprOpenGLImpl::renderBorderwith round/roundingPower for proper rounded cornersBackward Compatibility
Breaking Changes
gap_sizerenamed togaps_inouter_gapremoved (usegaps_out)border_color_current/focuschanged from INT to STRINGMigration Path
Deprecated (Still Supported)
border_style: Ignored, kept for backwards compatibilityborder_grad_current/focus/hover: Used as fallback if newborder_color_*is emptyPotential Follow-ups
col.active_border/col.inactive_borderwhen plugin gradient strings not setNote to maintainers: Feedback welcome on API shape and config naming; happy to adjust for consistency with core. If you prefer not to maintain these features, no worries—I'm already maintaining a fork at hyprexpo-plus.