Skip to content

Conversation

@outercloudstudio
Copy link
Contributor

Fixes #503

Removes second redundant check.

if (!workspace || !workspace) {
        Debug::log(ERR, "[scroller] broken internal state on workspace data");
        return;
}

https://github.com/hyprwm/hyprland-plugins/blob/7be897d6ae765fab756c0b7e6b91e8c5b39a419e/hyprscrolling/Scrolling.cpp#L278C3-L281C6

Changed to

if (!workspace) {
        Debug::log(ERR, "[scroller] broken internal state on workspace data");
        return;
}

@outercloudstudio outercloudstudio changed the title Remove redundant workspace check scrolling: remove redundant workspace check Oct 9, 2025
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey hey do the zombie stomp

@vaxerski vaxerski merged commit f6dd103 into hyprwm:main Oct 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspace is checked twice redundantly in hyprscrolling

2 participants