-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate EGL init/state #138
Conversation
I don't see the point? Breaks ABI, API, and what's the benefit? |
completely forgot about this lol but i don't want to do all that right now, so abi can be broken then if me or someone else ever tries after removing the abi breaking stuff, I would say this is just an overall improvement |
39d5694
to
f7433f2
Compare
f7433f2
to
e93a32f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically you break CRenderer abi but is that even used by hl directly?
uuh CDRMRenderer from aq? no HL doesn't use that directly |
no, dont |
next step is to use CEGLRenderer in HLreasoning: egl init, loading, and egl specific funcs (createEGLImage) are all in one place
note:egl queried formats don't have external modifiers stripped here, but hl impl does, so will deal with it in hl pr