-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anr: add xwayland support #9456
Conversation
worse than mine |
fixed, I guess that's what I get for blindly trusting your X usage and not reading the spec. |
💀 idk? #9436 works perfectly fine for me |
it's completely off spec |
wrong |
another mistake is that _NET_WM_PING is not required to be supported, the app reports whether it does. xeyes doesnt and under your MR it would always be marked as ANR |
read up on X11 WM_PROTOCOLS spec here https://specifications.freedesktop.org/wm-spec/1.4/ar01s06.html |
not an issue with the implementation though, we are just pinging the application. if it doesnt respond it doesnt respond |
if the app doesn't report supporting pings, we cannot mark it as always ANR because it might be responding, just not to your pings. |
i mean i get it but still................... thanks for pointing that out ig.................................... |
vaxry finally doing something for once |
my motivation is unreal |
review #9405 after this, been waiting too long |
supersedes #9436
for some reason xwayland apps dont wanna reply, dk why for now, but 9436 doesnt work on my end anyways