Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anr: add xwayland support #9456

Merged
merged 3 commits into from
Feb 21, 2025
Merged

anr: add xwayland support #9456

merged 3 commits into from
Feb 21, 2025

Conversation

vaxerski
Copy link
Member

supersedes #9436

for some reason xwayland apps dont wanna reply, dk why for now, but 9436 doesnt work on my end anyways

@nnyyxxxx
Copy link
Contributor

worse than mine

@vaxerski
Copy link
Member Author

fixed, I guess that's what I get for blindly trusting your X usage and not reading the spec.

@nnyyxxxx
Copy link
Contributor

fixed, I guess that's what I get for blindly trusting your X usage and not reading the spec.

💀 idk? #9436 works perfectly fine for me

@vaxerski
Copy link
Member Author

it's completely off spec

@nnyyxxxx
Copy link
Contributor

wrong

@vaxerski
Copy link
Member Author

another mistake is that _NET_WM_PING is not required to be supported, the app reports whether it does. xeyes doesnt and under your MR it would always be marked as ANR

@vaxerski
Copy link
Member Author

read up on X11 WM_PROTOCOLS spec here https://specifications.freedesktop.org/wm-spec/1.4/ar01s06.html

@nnyyxxxx
Copy link
Contributor

not an issue with the implementation though, we are just pinging the application. if it doesnt respond it doesnt respond

@vaxerski
Copy link
Member Author

if the app doesn't report supporting pings, we cannot mark it as always ANR because it might be responding, just not to your pings.

@nnyyxxxx
Copy link
Contributor

i mean i get it but still................... thanks for pointing that out ig....................................

@nnyyxxxx
Copy link
Contributor

vaxry finally doing something for once

@nnyyxxxx
Copy link
Contributor

my motivation is unreal

@nnyyxxxx
Copy link
Contributor

review #9405 after this, been waiting too long

@vaxerski vaxerski merged commit f4b148d into hyprwm:main Feb 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants