-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(window): add option to allow size persistence between app launches #9422
base: main
Are you sure you want to change the base?
Conversation
should this be per window or windows in general |
3c32912
to
d20c772
Compare
windowrule, preferably |
okay... |
not sure this is possible ive tried some shit but apps start flipping out with their scaling and shiz edit - maybe we can just reapply each apps previous floating size when floating is triggered or something |
can you give me opinions on this @vaxerski |
can't you just gate |
if we stop telling apps they are maximized then some apps like firefox dont scale properly |
and they dont even remember their previous floating size |
👍
should easily be |
what about this |
might be our UV calculations not liking CSD. Some apps, notably gtk ones, will draw csd no matter what unless they are maximized (because then the protocol doesn't allow them) I would love if the xdg_shell spec said the same about tiled modes but it doesn't and I can't suggest the change due to being banned. |
damn bro is banned 💀 thats crazy... |
freedesktop shenanigans |
f6799e0
to
890e815
Compare
this is ready ✔️ |
wiki : hyprwm/hyprland-wiki#983 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
we could do this for x windows as well, though i dont know if that will blow some app up lol or if its even necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where this disables the maximized hints. It doesn't, in fact.
yeah actually we dont need to disable maximize hints, if we do, some apps like firefox wont scale properly. if we do it this way, apps like firefox will scale properly, and all apps will remember their size after app restart. do you want me to rename the window rule to somethin else? |
we could just keep it how it is, and just masquerade that it disables maximize hints |
I'll just rename the window rule |
049c14d
to
369547c
Compare
this is ready |
fixes #9171