Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(window): add option to allow size persistence between app launches #9422

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nnyyxxxx
Copy link
Contributor

fixes #9171

@nnyyxxxx
Copy link
Contributor Author

should this be per window or windows in general

@nnyyxxxx nnyyxxxx force-pushed the patch-3 branch 2 times, most recently from 3c32912 to d20c772 Compare February 16, 2025 14:43
@vaxerski
Copy link
Member

windowrule, preferably

@nnyyxxxx
Copy link
Contributor Author

windowrule, preferably

okay...

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Feb 21, 2025

not sure this is possible

ive tried some shit but apps start flipping out with their scaling and shiz

edit -

maybe we can just reapply each apps previous floating size when floating is triggered or something

@nnyyxxxx
Copy link
Contributor Author

can you give me opinions on this @vaxerski

@littleblack111
Copy link
Contributor

can't you just gate changeWindowFullscreenModeClient or setWindowFullscreenClient from actually executing, with the windowrule?

@nnyyxxxx
Copy link
Contributor Author

if we stop telling apps they are maximized then some apps like firefox dont scale properly

@nnyyxxxx
Copy link
Contributor Author

and they dont even remember their previous floating size

@vaxerski
Copy link
Member

can you give me opinions on this @vaxerski

👍

not sure this is possible

should easily be

@nnyyxxxx
Copy link
Contributor Author

if we stop telling apps they are maximized then some apps like firefox dont scale properly

what about this

@vaxerski
Copy link
Member

might be our UV calculations not liking CSD.

Some apps, notably gtk ones, will draw csd no matter what unless they are maximized (because then the protocol doesn't allow them)

I would love if the xdg_shell spec said the same about tiled modes but it doesn't and I can't suggest the change due to being banned.

@nnyyxxxx
Copy link
Contributor Author

I can't suggest the change due to being banned.

damn bro is banned 💀 thats crazy...

@littleblack111
Copy link
Contributor

might be our UV calculations not liking CSD.

Some apps, notably gtk ones, will draw csd no matter what unless they are maximized (because then the protocol doesn't allow them)

I would love if the xdg_shell spec said the same about tiled modes but it doesn't and I can't suggest the change due to being banned.

freedesktop shenanigans

@nnyyxxxx nnyyxxxx force-pushed the patch-3 branch 2 times, most recently from f6799e0 to 890e815 Compare February 24, 2025 04:32
@nnyyxxxx nnyyxxxx marked this pull request as ready for review February 24, 2025 05:52
@nnyyxxxx
Copy link
Contributor Author

this is ready ✔️

@nnyyxxxx
Copy link
Contributor Author

wiki : hyprwm/hyprland-wiki#983

Copy link
Contributor

@littleblack111 littleblack111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nnyyxxxx
Copy link
Contributor Author

we could do this for x windows as well, though i dont know if that will blow some app up lol or if its even necessary

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where this disables the maximized hints. It doesn't, in fact.

@nnyyxxxx
Copy link
Contributor Author

I don't see where this disables the maximized hints. It doesn't, in fact.

yeah actually we dont need to disable maximize hints, if we do, some apps like firefox wont scale properly.

if we do it this way, apps like firefox will scale properly, and all apps will remember their size after app restart.

do you want me to rename the window rule to somethin else?

@nnyyxxxx
Copy link
Contributor Author

we could just keep it how it is, and just masquerade that it disables maximize hints

@nnyyxxxx
Copy link
Contributor Author

I'll just rename the window rule

@nnyyxxxx nnyyxxxx force-pushed the patch-3 branch 3 times, most recently from 049c14d to 369547c Compare February 25, 2025 16:53
@nnyyxxxx nnyyxxxx changed the title feat(window): add option to disable maximized hints feat(window): add option to allow size persistence between app launches Feb 25, 2025
@nnyyxxxx nnyyxxxx marked this pull request as draft February 25, 2025 16:58
@nnyyxxxx
Copy link
Contributor Author

this is ready

@nnyyxxxx nnyyxxxx marked this pull request as ready for review February 25, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have option to not tell windowns they are maximized
3 participants