Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(xwayland): improve dnd and cleanup #9405

Merged
merged 6 commits into from
Feb 24, 2025
Merged

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Feb 14, 2025

fixes #9154
fixes #8964
fixes #8994
fixes #9472

@nnyyxxxx nnyyxxxx marked this pull request as ready for review February 14, 2025 03:28
@nnyyxxxx nnyyxxxx marked this pull request as draft February 14, 2025 04:58
@nnyyxxxx
Copy link
Contributor Author

some edge cases

@nnyyxxxx
Copy link
Contributor Author

g2g

@nnyyxxxx nnyyxxxx marked this pull request as ready for review February 14, 2025 08:06
@vaxerski
Copy link
Member

christ, I'll have to test this myself a bit because in the dnd code when you touch something then some fucking app implodes

@nnyyxxxx
Copy link
Contributor Author

christ, I'll have to test this myself a bit because in the dnd code when you touch something then some fucking app implodes

should be good lmk how that goes

@nnyyxxxx
Copy link
Contributor Author

did you find any bugs with this? @vaxerski or nah

@vaxerski
Copy link
Member

I should make a rule that every time you ping me I delay my review by 2 days

@vaxerski
Copy link
Member

vaxerski commented Feb 15, 2025

dnd dolphin -> kitty = broken by this
dnd dolphin -> chromium tabs = broken by this (in the middle is fine, onto the tab bar to open as new tab is broken)

took me just 2 minutes

@nnyyxxxx
Copy link
Contributor Author

atleast its better than before lol

@nnyyxxxx nnyyxxxx marked this pull request as draft February 15, 2025 14:00
@nnyyxxxx
Copy link
Contributor Author

can you explain what u mean by broken lol

@nnyyxxxx
Copy link
Contributor Author

nvm i see now

@nnyyxxxx
Copy link
Contributor Author

broke more shit

@nnyyxxxx
Copy link
Contributor Author

atleast kitty is fixed now

@nnyyxxxx
Copy link
Contributor Author

kitty officially fixed

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Feb 15, 2025

kitty officially fixed

image

@nnyyxxxx
Copy link
Contributor Author

It's an event ordering issue on our part.

mpv-player/mpv#15939 (comment)

e

@Zebra2711
Copy link

Why are you so toxic? Do you know how to read, or do you type faster than you think? If you want to be clear, just say, "That is not an issue with hyprland." So, should I create an issue for something other than hyprland instead? That's fine—I will create issues for dolphin, mpv, etc. But what I want to mention here is that I believe this issue comes from both sides. And one last thing: is your code impeccable?

@nnyyxxxx
Copy link
Contributor Author

what 💀

@nnyyxxxx
Copy link
Contributor Author

@fufexan
Copy link
Member

fufexan commented Feb 23, 2025

I agree. @nnyyxxxx, you're being toxic and spammy. Please tone it down.

@nnyyxxxx
Copy link
Contributor Author

my bad

@vaxerski
Copy link
Member

@nnyyxxxx I do realize you are trying to contribute code, but you are repeatedly trying my patience. If you keep being this abrasive, you will be banned.

@nnyyxxxx
Copy link
Contributor Author

my bad

@vaxerski
Copy link
Member

vaxerski commented Feb 23, 2025

can't dnd from dolphin to any xwayland app with this MR. It did work last time I reviewed.

@nnyyxxxx
Copy link
Contributor Author

i didnt even change anything

@vaxerski
Copy link
Member

hm, right, it doesn't work on main either.

@nnyyxxxx
Copy link
Contributor Author

try rebooting 💀

@nnyyxxxx
Copy link
Contributor Author

this pr works fine for me

@vaxerski
Copy link
Member

9228116 regressor

@nnyyxxxx
Copy link
Contributor Author

??

@nnyyxxxx
Copy link
Contributor Author

that doesnt even touch dnd

@vaxerski
Copy link
Member

of course it does :)

@nnyyxxxx
Copy link
Contributor Author

2025-02-23.17-46-51.mp4

this is on latest -git

@vaxerski
Copy link
Member

hm, okay, nevermind. It's just really dicey. It doesn't work with some filetypes. Maybe some mime weirdness.

@vaxerski
Copy link
Member

the dolphin bug is still there but it's way better than main, so I'm fine with this.

vaxerski
vaxerski previously approved these changes Feb 23, 2025
@vaxerski
Copy link
Member

actually, sec.

@vaxerski
Copy link
Member

there we go

@nnyyxxxx
Copy link
Contributor Author

💀

@nnyyxxxx
Copy link
Contributor Author

but it's way better than main, so I'm fine with this.

of course

@vaxerski vaxerski merged commit 3458d7a into hyprwm:main Feb 24, 2025
12 checks passed
@nnyyxxxx nnyyxxxx deleted the patch-2 branch February 24, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment