Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render): disable explicit if aquamarine output doesn't support it #9398

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

aruhier
Copy link
Contributor

@aruhier aruhier commented Feb 13, 2025

Describe your PR, what does it fix/add?

Fixes #9396.

The explicit settings ignore the aquamarine output.supportsExplicit attribute, which creates glitches on drivers not supporting explicit sync (example: freedreno).

If the output has been set as not supporting explicit, disable the explicit settings.

Is it ready for merging, or does it need work?

Ready to merge.

…yprwm#9396)

The explicit settings ignore the aquamarine output.supportsExplicit
attribute, which creates glitches on drivers not supporting explicit
sync (example: freedreno).

If the output has been set as not supporting explicit, disable the
explicit settings.
@aruhier aruhier force-pushed the pr_check_output_explicit_sync branch from c09400d to 7a85bca Compare February 13, 2025 01:40
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit 5d2b008 into hyprwm:main Feb 13, 2025
12 checks passed
andrewandreii pushed a commit to andrewandreii/Hyprland that referenced this pull request Feb 15, 2025
…yprwm#9396) (hyprwm#9398)

The explicit settings ignore the aquamarine output.supportsExplicit
attribute, which creates glitches on drivers not supporting explicit
sync (example: freedreno).

If the output has been set as not supporting explicit, disable the
explicit settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hyprland needs to check DRM_CAP_SYNCOBJ_TIMELINE
2 participants