Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DS and VRR automation #9334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

UjinT34
Copy link
Contributor

@UjinT34 UjinT34 commented Feb 5, 2025

Describe your PR, what does it fix/add?

Fix DS automation conditions. Fixes #9331
Fix VRR auto activation. Might fix #9230
Add misc:vrr = 3 to auto enable VRR for game or video content types. Can be used instead of a window rule #7621

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

There is no need to commit VRR state and deal with explicit sync inside ensureVRR. Next rendered frame should pickup new desired state. Legacy renderer is untested.
Needs more testing with vrr = 2 or vrr = 3 and monitors without VRR support.

Is it ready for merging, or does it need work?

Ready

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Feb 5, 2025

might wanna drop DS changes

@zakk4223
Copy link
Contributor

zakk4223 commented Feb 5, 2025

Isn't this all supposed to be gated behind the window being solitary anyways? DS requires a solitary window on the monitor and I assume so should vrr. PMONITOR->solitaryClient

@UjinT34
Copy link
Contributor Author

UjinT34 commented Feb 5, 2025

Isn't this all supposed to be gated behind the window being solitary anyways? DS requires a solitary window on the monitor and I assume so should vrr. PMONITOR->solitaryClient

direct_scanout = 1 works this way.
direct_scanout = 2 also checks for a fullscreen window with game content type to avoid DS activation for apps that don't work well with DS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VRR Pink Screen Flicker direct_scanout=2 crashes
3 participants