Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchpad gestures: workspace speed multiplier #9121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thicileares
Copy link

Describe your PR, what does it fix/add?

  • When using the workspace swipe gestures, the movement was too fast for my liking.
  • So I added a config option to slow down (or speed up) the movement by an arbitrary factor.

For example:

  • workspace_swipe_speed_multiplier = 1: windows will move one-to-one with touchpad movement (current, default behavior)
  • workspace_swipe_speed_multiplier = 0.5: windows will move half as fast when swiping on the touchpad
  • workspace_swipe_speed_multiplier = 2: windows will move twice as fast

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Pretty basic addition and I think it would be useful for others.

Is it ready for merging, or does it need work?

Ready to merge (as far as I can tell).

@earboxer
Copy link
Contributor

Is this just the inverse of workspace_swipe_distance?

If so, I think this should replace that, unless there's some reasonable reason to have both....

@thicileares
Copy link
Author

Is this just the inverse of workspace_swipe_distance?

Ah you are right. Looking at the code, it is the exact inverse. I didn't realize that... perhaps the docs could be revised to be a little more clear? "Distance of the touch pad gesture" didn't make sense to me, so I didn't think to change that.

If so, I think this should replace that, unless there's some reasonable reason to have both....

As for which one should be kept:

  • I think my option makes more sense at a conceptual level. As a user, altering the "speed" of something with a multiplier is more intuitive than the thing going on now, which is to specify the amount of pixels one needs to move on the trackpad to move over one workspace. (I can't think of a better way to phrase it. See what I mean?)
  • Therefore this option would also be easier to properly document

On the other hand:

  • As I tried to explain above, the distance is currently used to calculate the percentage of the workspace that is to be translated during the animation.
    • The calculation of this percentage would either have to be fixed to some value, or
    • How the workspaces are translated would have to be refactored somehow. I don't know how yet.

Cleaning this all up would be a good thing, and would make this basic functionality more accessible. If there is any interest in replacing workspace_swipe_distance with this option, I could try to put in another PR this weekend.

Let me know if I should try to tackle this or if this is not a priority.

@vaxerski
Copy link
Member

I don't see a problem with the current system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants