windowrules: add fullscreenstate field

[sungyoonc]

Describe your PR, what does it fix/add?

Add fullscreenstate field for window rules v2.

fullscreenstate: [internal] [client] matches windows with specific fullscreen state.

For example

• fullscreenstate:0 1 matches windows that have internal state of 0 and client state of 1.
• fullscreenstate:* 2 matches windows that have client state of 2 (internal state can be anything).

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Accompanying wiki MR: hyprwm/hyprland-wiki#757

Is it ready for merging, or does it need work?

Ready for merging.

[vaxerski]

why not make "any" a * instead of -1, or allow both?

[sungyoonc]

why not make "any" a * instead of -1, or allow both?

Made any a *.

[vaxerski]

with this we can nuke fullscreen in a future mr

[Buttars]

@vaxerski can we get better documentation around what "internal" and "client" refers to?

[vaxerski]

MRs welcome. Internal means what hyprland does. Client means what the client receives

[Buttars]

MRs welcome. Internal means what hyprland does. Client means what the client receives

I'm happy to open a PR(MR?) if you can help me understand the implications. Specifically I have tried every combination of settings of fullscreenstate to make it so my brave browser does not go into fullscreen mode on the client yet it goes into that "fullscreen presentation" F11 style mode every time.

If this isn't the appropriate place to discuss this let me know how I can reach out.

[MightyPlaza]

MRs welcome. Internal means what hyprland does. Client means what the client receives

I'm happy to open a PR(MR?) if you can help me understand the implications. Specifically I have tried every combination of settings of fullscreenstate to make it so my brave browser does not go into fullscreen mode on the client yet it goes into that "fullscreen presentation" F11 style mode every time.

If this isn't the appropriate place to discuss this let me know how I can reach out.

F11 is controlled by brave, so it will control the client fullscreen mode
You need to use a dispatcher to make it fullscreen (fullscreenstate 2 0)
additionally the style can likely be changed

[Buttars]

@MightyPlaza This worked perfectly. My problem is I was trying to apply it as a window rule.

I'll open a PR to update the documentation soon. Thanks!

[Buttars]

@MightyPlaza @vaxerski thanks kings 👑 👉🏻 hyprwm/hyprland-wiki#892