WindowRuleApplicator: Fix application of dynamic rules passed via exec dispatcher #12512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
As described here: #12434 (reply in thread), currently dynamic rules are not properly applied when passed via the exec dispatcher. This PR modifies the the signature of CWindowRuleApplicator::applyDynamicRule to include a param for override priority. This didn't necessarily need to be a new function param and could just be calculated inside the applyDynamicRule function, but I thought this was more flexible.
This does not fix all of the issues mentioned in my comment linked above, only the part about dynamic rules.