anr: open anr dialog on parent's workspace #12509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
fixes #11287
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Since exec rules have a 1 second timeout, is it better to postpond the creation of the rule until
CAsyncDialogBox::opencall, or is the current approach fine?Is it ready for merging, or does it need work?
Only tested it with simple client idk any other, but works great
Edit:
Actually it doesn't work with special workspaces. Workspace rule doesn't work with special workspace ids, only their names like--- should be fixedspecial:magic