Skip to content

Conversation

@vaxerski
Copy link
Member

@vaxerski vaxerski commented Nov 29, 2025

Because we now properly include ABI info in our version string, hyprpm should take that into account when checking if we need to update.

Ref outfoxxed/hy3#254
Ref hyprwm/hyprland-plugins#552

Needs a quick test

@vaxerski
Copy link
Member Author

vaxerski commented Dec 1, 2025

@VirtCode have you had a chance to verify this is working

@VirtCode
Copy link
Contributor

VirtCode commented Dec 1, 2025

I don't use hyprpm myself but I can quickly have a look whether things still work as expected (could also try to simulate an ABI break with some downgrading but I'll see). Will be back later this evening, need to finish an assignment first.

@vaxerski
Copy link
Member Author

vaxerski commented Dec 1, 2025

thanks bae xoxo

@VirtCode
Copy link
Contributor

VirtCode commented Dec 2, 2025

sorry honey, won't get to it today anymore, will see tomorrow morning. That assignment literally drove me insane I gotta get some sleep first.

@vaxerski
Copy link
Member Author

vaxerski commented Dec 2, 2025

no prob qt

@VirtCode
Copy link
Contributor

VirtCode commented Dec 2, 2025

Okay finally got around to it. Currently hyprpm update does not work with an empty cache. Always fails with "ABI is mismatched.", even with --force. So to reproduce, just run hyprpm purge-cache and then hyprpm update.

I had a quick glance at the code and I guess the issue is that headersValid() checks against the hash in the global state, and fails if it doesn't match. In our case the global state doesn't exist yet as we seem to write it after checking header validity? But a similar thing would happen if our state contains an old hash, so I don't know whether that's really what's happening.

@vaxerski
Copy link
Member Author

vaxerski commented Dec 2, 2025

check nwo @VirtCode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants