Refactor/IHprLayout #10796
Open
Refactor/IHprLayout #10796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid flooding
Throttle timer loop to avoid high CPU usage and track idle callbacks …
…llbacks to avoid flooding" This reverts commit 318688e.
|
@vaxerski This refactor can be merged. |
|
No, I don't think so. What does this refactor achieve? There are no benefits functionally, only potential (and wouldn't be the first time) regressions. You're rewriting a large part of code that has had historically dozens of small edge cases and issues, in a huge unreviewable dollop. In general, I am not in favor of huge refactors for no gain, only because "uhh code looks complicated". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Split the performSnap and onMouseMove function to make it easier to test and work with.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
no
Is it ready for merging, or does it need work?
yes, is ready I don't want to make the PR too big