refactor(xwayland): improve dnd and cleanup #9405
Conversation
|
some edge cases |
|
g2g |
|
christ, I'll have to test this myself a bit because in the dnd code when you touch something then some fucking app implodes |
should be good lmk how that goes |
|
did you find any bugs with this? @vaxerski or nah |
|
I should make a rule that every time you ping me I delay my review by 2 days |
|
dnd dolphin -> kitty = broken by this took me just 2 minutes |
|
atleast its better than before lol |
|
can you explain what u mean by broken lol |
|
nvm i see now |
|
broke more shit |
|
atleast kitty is fixed now |
|
kitty officially fixed |
|
e |
|
Why are you so toxic? Do you know how to read, or do you type faster than you think? If you want to be clear, just say, "That is not an issue with hyprland." So, should I create an issue for something other than hyprland instead? That's fine—I will create issues for dolphin, mpv, etc. But what I want to mention here is that I believe this issue comes from both sides. And one last thing: is your code impeccable? |
|
what 💀 |
|
I agree. @nnyyxxxx, you're being toxic and spammy. Please tone it down. |
|
my bad |
|
@nnyyxxxx I do realize you are trying to contribute code, but you are repeatedly trying my patience. If you keep being this abrasive, you will be banned. |
|
my bad |
|
can't dnd from dolphin to any xwayland app with this MR. It did work last time I reviewed. |
|
i didnt even change anything |
|
hm, right, it doesn't work on main either. |
|
try rebooting 💀 |
|
this pr works fine for me |
|
9228116 regressor |
|
?? |
|
that doesnt even touch dnd |
|
of course it does :) |
2025-02-23.17-46-51.mp4this is on latest -git |
|
hm, okay, nevermind. It's just really dicey. It doesn't work with some filetypes. Maybe some mime weirdness. |
|
the dolphin bug is still there but it's way better than main, so I'm fine with this. |
|
actually, sec. |
|
there we go |
|
💀 |
of course |
fixes #9154
fixes #8964
fixes #8994
fixes #9472