Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GPU-aware MPI runtime switch logic #1232

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Fix GPU-aware MPI runtime switch logic #1232

merged 2 commits into from
Feb 7, 2025

Conversation

victorapm
Copy link
Contributor

Closes #1231

@jczhang07 this should fix your issue

@liruipeng
Copy link
Contributor

Did you just change #if !defined(HYPRE_USING_GPU_AWARE_MPI) to if (GPU_aware), i.e., #if/#else to if/else? If so, can you keep the other lines unchanged (changes that are not necessary), so it can make my merge easier. Note these will be all gone eventually when the mpi branch is ready. Thanks @victorapm

liruipeng
liruipeng approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@liruipeng liruipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks!

@victorapm victorapm merged commit 19ecc97 into master Feb 7, 2025
@victorapm victorapm deleted the fix-gpuaw branch February 7, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruipeng liruipeng liruipeng approved these changes

@rfalgout rfalgout rfalgout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with GPU-aware MPI option
3 participants
@victorapm @liruipeng @rfalgout