Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UserDeleteService to use roles not users #9049

Open
wants to merge 1 commit into
base: missing-test-coverage
Choose a base branch
from
Open

Update UserDeleteService to use roles not users #9049

wants to merge 1 commit into from

Commits on Nov 1, 2024

  1. Delete groups based on owners not creator 

    When deleting a user account we currently delete any groups that the
user created and that don't contain any annotations by other users.

This made sense when the creator was the only person who could edit the
group (changing its name, description and type) or moderate annotations
in the group: groups with no creator were kind of broken and may as well
be deleted (as long as they didn't contain any annotations).

But we've now added the concept of group membership roles and in
particular a group can have multiple "owners" who all have full
permissions to edit and moderate the group. Even if the group's creator
no longer exists, the group may still have other owners who have full
control of the group.

So instead of deleting groups that the user created, change
`UserDeleteService` to delete groups that the user is the only owner of
(and that don't contain any annotations by other users).
    @seanh
    seanh committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a8c4bf6 View commit details
    Browse the repository at this point in the history