Move mock filter impl to testing package #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
commented
Jun 21, 2021
| @@ -148,20 +148,4 @@ public void get() throws IOException, InterruptedException { | |||
| // Assertions.assertEquals(1, responseBodyAttributes.size()); | |||
| // Assertions.assertEquals("Hi!", responseBodyAttributes.get(0)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void blocking() throws IOException { | |||
There was a problem hiding this comment.
this is obviously a loss. To make this test work with mock filer not being in the final distribution we will have to build test java agent distro - this might be related to #238
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
force-pushed
the
move-mock-filter-to-test
branch
from
8479d6f to
309f95d
Compare
shashank11p
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay [email protected]
Description
Before this PR the mock filter implementation was packaged in the agent distribution. The mock filter shouldn't be exposed in the final distribution. Its only purpose is to test blocking in instrumentations which is done by moving the filter into the testing package.