Add OTEL smoke test #268
Merged
Add OTEL smoke test #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
reviewed
Feb 17, 2021
Makefile
Outdated
| @@ -7,11 +7,11 @@ assemble: | |||
|
|
|||
| .PHONY: build | |||
| build: | |||
| ./gradlew build -x :smoke-tests:test --stacktrace | |||
| ./gradlew build -x :smoke-tests:test --debug --stacktrace | |||
There was a problem hiding this comment.
is this needed? I don't like to run debug locally. As below in the smoke-test target
There was a problem hiding this comment.
have removed the debug option
gradle/dependencies.gradle
Outdated
| @@ -0,0 +1,97 @@ | |||
| def groovyVer = "2.5.11" | |||
There was a problem hiding this comment.
Do we need this file and the java.gradle?
in OTEL repo these are reused for other modules. since we have only smoke tests module we could copy there only what is needed. For instance we define versions in our root build script.
There was a problem hiding this comment.
@pavolloffay have removed dependencies.gradle but not java.gradle.
pavolloffay
approved these changes
Feb 18, 2021
|
@samarth-gupta-traceable the next step will be to modify the apps to include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #217
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
ran ./gradlew build locally
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.