Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for logical operators #148

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Add support for specifying a logical operator at the top level of a request. Previously it had defaulted to always be AND.

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner November 5, 2023 16:40
Copy link

github-actions bot commented Nov 5, 2023

Test Results

110 tests  ±0   110 ✔️ ±0   1m 4s ⏱️ +11s
  38 suites ±0       0 💤 ±0 
  38 files   ±0       0 ±0 

Results for commit dfc06e8. ± Comparison against base commit 6f68e95.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #148 (dfc06e8) into main (6f68e95) will decrease coverage by 0.19%.
The diff coverage is 37.50%.

@@             Coverage Diff              @@
##               main     #148      +/-   ##
============================================
- Coverage     57.57%   57.39%   -0.19%     
- Complexity      264      265       +1     
============================================
  Files            91       92       +1     
  Lines          1445     1460      +15     
  Branches         42       42              
============================================
+ Hits            832      838       +6     
- Misses          583      592       +9     
  Partials         30       30              
Flag Coverage Δ
unit 57.39% <37.50%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...esults/arguments/filter/LogicalFilterOperator.java 100.00% <100.00%> (ø)
...common/request/DefaultResultSetRequestBuilder.java 51.57% <60.00%> (+0.46%) ⬆️
...core/graphql/utils/gateway/GatewayUtilsModule.java 0.00% <0.00%> (ø)
...ce/core/graphql/utils/gateway/FilterConverter.java 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aaron-steinfeld aaron-steinfeld marked this pull request as draft November 6, 2023 02:18
@aaron-steinfeld
Copy link
Contributor Author

Converting to a draft for now. I may redo this as a filter variant to support nested use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant