Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use opaque key to identify trace-provider #241

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

thugrock7
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.49%. Comparing base (1fd91b9) to head (a883c20).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
instrumentation/opentelemetry/init.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   59.37%   59.49%   +0.11%     
==========================================
  Files          72       72              
  Lines        2895     2903       +8     
==========================================
+ Hits         1719     1727       +8     
  Misses       1095     1095              
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tim-mwangi tim-mwangi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the static analysis is failing gosec and not producing a report.

@varkey98
Copy link
Contributor

I asked @senanjude0 about this and he told me when we raise prs from this repo itself instead of a fork, the static analysis will run fine

For some reason the static analysis is failing gosec and not producing a report.

@thugrock7 thugrock7 merged commit 583b5da into hypertrace:main Nov 6, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants