Skip to content

restore accidentally removed UI code to load latest version correctly #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

shivaji-kharse
Copy link
Contributor

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to
    this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo
    staged and linked here

Instructions

  • The PR title should follow the Conventional Commits
    syntax, leading with fix:, feat:, chore:, ci:, etc.
  • The description should briefly explain what the PR is about. In the case of a bugfix, describe or
    link to the bug.
  • In the checklist section, check the boxes in that are applicable, using [x] syntax. If not
    applicable, remove the entire line. Only leave the box unchecked if you intend to come back and
    check the box later.
  • Delete the Instructions line and everything below it, to indicate you have read and are
    following these instructions. 🙂

Thank you for your contribution to Dgraph!

@Copilot Copilot AI review requested due to automatic review settings June 13, 2025 09:04
Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ratel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 0:26am

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reformats the RATEL_CDN_MAP object and adds a temporary override to always load the latest CDN version.

  • Replaced quoted keys with unquoted property names in RATEL_CDN_MAP
  • Inserted a temporary override (forcing codeVersion and storedCdn to "latest")
Comments suppressed due to low confidence (1)

client/public/index.html:505

  • This assignment creates an implicit global variable. It would be safer to explicitly declare it (e.g., let storedCdn = "latest";) or ensure it's already declared in the proper scope.
storedCdn = "latest";

@shivaji-kharse shivaji-kharse changed the title revert change restore accidentally removed UI code to load latest version correctly Jun 13, 2025
@shivaji-kharse shivaji-kharse merged commit cfd3b25 into main Jun 16, 2025
8 checks passed
@shivaji-kharse shivaji-kharse deleted the shiva/latet-ratel branch June 16, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants